Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited scenes produce errors in editor when "editable_children" is true. #87424

Closed
bhottovy opened this issue Jan 21, 2024 · 2 comments · Fixed by #88426
Closed

Inherited scenes produce errors in editor when "editable_children" is true. #87424

bhottovy opened this issue Jan 21, 2024 · 2 comments · Fixed by #88426

Comments

@bhottovy
Copy link

Tested versions

Reproducible in mono 4.3.dev2

System information

Windows 11 Intel(R) Core(TM) i7-12700H CPU @ 2.30GHz

Issue description

When a base scene (containing at least one child) is inherited and the inherited scene is instanced inside of a parent scene and has 'editable_children' = true then saving the parent scene or selecting one of the editable children inside of this instanced node spams the output with this error:

image

This error does not happen when the base scene does not have any children.

Seems to happen regardless of node types.

Steps to reproduce

  1. Create a base scene and add at least 1 child node.
    image
  2. Create a new inherited scene from the base scene.
    image
  3. Create a new 'parent' scene and instance the inherited scene inside of it. Set the 'editable_children' of the instance to true.
    image
  4. Now either selecting the child node inside of the inherited instance or saving the parent scene will spam the previous error to the console.
    image
    image

Minimal reproduction project (MRP)

BugReportMRP.zip

@AlexOtsuka
Copy link
Contributor

AlexOtsuka commented Jan 22, 2024

I was able to reproduce this in 4.3, but not in 4.2.1 where this doesn't throw any errors.

Edit: Maybe has something to do with cb8a743 ?

@bhottovy bhottovy changed the title Output spams "index out of bounds" errors when instancing an inherited scene with "editable_children" set to true. Inherited scenes produce errors in editor when "editable_children" is true. Jan 25, 2024
@akien-mga akien-mga added this to the 4.3 milestone Feb 17, 2024
@sketchyfun
Copy link
Contributor

sketchyfun commented Feb 24, 2024

I'm not sure if it's related (although I am getting the exact same error spam as the original post), but I've also noticed that inherited scenes with editable children enabled can end up having their resources duplicated and saved as part of the parent scene instead of using the original resource path of the instanced scene. Here's an example of a SpriteFrames resource on my player scene

As you can see it's being stored in the stage scene, which is wrong
2024-02-24 22_02_36-(_) stage9 tscn - Ex-Zodiac - Godot Engine

And then after I click the little reset icon next to the SpriteFrames resource, it resets back to what's stored in the instanced scene

2024-02-24 22_09_10-stage9 tscn - Ex-Zodiac - Godot Engine

I've only been noticing this recently, so I thought it might coincide with this, but if you'd rather I open a separate ticket for it, I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants