Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Show in Filesystem when FileSystem is at the bottom #88000

Closed
kitbdev opened this issue Feb 5, 2024 · 0 comments · Fixed by #88003
Closed

Crash on Show in Filesystem when FileSystem is at the bottom #88000

kitbdev opened this issue Feb 5, 2024 · 0 comments · Fixed by #88003

Comments

@kitbdev
Copy link
Contributor

kitbdev commented Feb 5, 2024

Tested versions

Godot v4.3.dev (10e1114) (since #86765)

System information

Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 (NVIDIA; 31.0.15.4665) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)

Issue description

The Editor will crash when Show in Filesystem is called from anywhere while the Filesystem is at the bottom panel.

FileSystemDock::navigate_to_path() assumes that the FileSystem is in a TabContainer if it is in the same window, but when it is at the bottom panel it is not, so the cast fails and is null when set_current_tab() is called on it.

I am working on a PR that will fix this issue.

Steps to reproduce

  • Move the FileSystem to the Bottom Panel
  • Click on Show in Filesystem from the context menu on a Scene root, script in the script list, or resource in the inspector.
  • The editor crashes.

Minimal reproduction project (MRP)

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants