Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange effect with shadows enabled on DirectionalLight #8817

Closed
eon-s opened this issue May 18, 2017 · 5 comments
Closed

Strange effect with shadows enabled on DirectionalLight #8817

eon-s opened this issue May 18, 2017 · 5 comments

Comments

@eon-s
Copy link
Contributor

eon-s commented May 18, 2017

Godot version: master 32afcbc but more recent too

Issue description:
Using default settings, when turning shadows on on a DirectionalLight, the editor get some weird effect on textures.
Camera viewport get less noisy output and the running camera even less, but is still there.

shadowbug

I think the effect is not present on OmniLight and just at some extent on SpotLight (faces parallel to the light direction).
This may be a bad default setting issue, but not sure.

Steps to reproduce:
Add a directional light to a 3D scene and enable shadows.

Link to minimal example project:

shadowtest.zip

@Zireael07
Copy link
Contributor

Looks very close to my weird flashes from #8651, so chances are the two are related.

@eon-s
Copy link
Contributor Author

eon-s commented May 19, 2017

This problem doe not exists in a late january build (just the problem that every gizmo produces shadow).

@reduz
Copy link
Member

reduz commented Jun 12, 2017

hmm this looks like default shadow bias setting, should investigate

@eon-s
Copy link
Contributor Author

eon-s commented Jun 13, 2017

A normal bias (not shadow) of around 0.7 make the strips disappear but not sure if is the correct setting.

@reduz
Copy link
Member

reduz commented Jun 14, 2017

Rewrote the way bias works in DirectionalLights, this should make it work much better. Also changed default settings so it looks good on the first attempt

@reduz reduz closed this as completed Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants