Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated BoneAttachment3D Performance Impact #92775

Open
fabius opened this issue Jun 4, 2024 · 3 comments
Open

Animated BoneAttachment3D Performance Impact #92775

fabius opened this issue Jun 4, 2024 · 3 comments

Comments

@fabius
Copy link

fabius commented Jun 4, 2024

Tested versions

  • Reproducible in 4.3.beta1, 4.2-stable

System information

Godot v4.3.beta1 - NixOS #1-NixOS SMP PREEMPT_DYNAMIC Fri May 17 10:18:09 UTC 2024 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX () - AMD Ryzen 5 7600X 6-Core Processor (12 Threads)

Issue description

Spawning multiple animated Skeleton3D nodes with BoneAttachment3D nodes inside, performance drops way more than it should. (about 50-80% on my rig with 20 skeletons)
I'd expect the FPS impact to be less significant than that.

Steps to reproduce

  • have multiple characters with BoneAttachment3D nodes inside their skeletons
  • free attachments (see MRP)
  • watch FPS increase

Minimal reproduction project (MRP)

https://github.com/fabius/tps-demo

press space to free all attachments

@AThousandShips
Copy link
Member

What 4.3 hash are you using? There's no 4.3-stable yet unless you're a time traveller 😉 please add the sha of the commit you're using (or a pre-release if you're using one)

@fabius
Copy link
Author

fabius commented Jun 4, 2024

whoops, sorry, meant to say 4.3 beta. Edited the issue

@TokageItLab
Copy link
Member

I believe that 4.3 is somewhat better than 4.2 by #90575, but I have not yet been able to get proper measurements. We are in the process of planning a benchmake for animation performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants