Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project settings are slow to take effect #93209

Open
miv391 opened this issue Jun 15, 2024 · 4 comments
Open

Project settings are slow to take effect #93209

miv391 opened this issue Jun 15, 2024 · 4 comments

Comments

@miv391
Copy link
Contributor

miv391 commented Jun 15, 2024

Tested versions

Reproducible in v4.3.beta1.mono.official [a4f2ea9]

System information

Godot v4.3.beta1.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; 32.0.15.5599) - Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz (4 Threads)

Issue description

If I run the project (pressing F5) immediately after changing some project setting (Display | Window | Viewport Height for example), the project still uses the old setting value. If I wait a few seconds (maybe about 3 seconds on my computer) before starting the project, the new setting value has been taken effect. The problem happens most easily when just typing the new numeric setting value without pressing enter and closing the Project Setting window by clicking the Close button and then immediately pressing F5.

I would expect that the changed settings would take effect before it is possible to start the project.

Steps to reproduce

  1. Open Project Setting
  2. Type some new value to Display | Window | Viewport Height, do not press enter!
  3. Click Close button
  4. Immediately press F5 to start the project --> old window height is still used
  5. Press F8 to stop
  6. Press F5 to start the project again --> new window height is used

Minimal reproduction project (MRP)

N/A

@AThousandShips
Copy link
Member

The part about not pressing enter seems relevant and seems like the editor doesn't mark the option as changed for saving before running the project

@miv391
Copy link
Contributor Author

miv391 commented Jun 16, 2024

The part about not pressing enter seems relevant and seems like the editor doesn't mark the option as changed for saving before running the project

I can reproduce the problem also by pressing enter before closing the Settings Windows, but I need to be fast.

@Calinou
Copy link
Member

Calinou commented Jun 16, 2024

@zaddok
Copy link

zaddok commented Sep 9, 2024

A similar problem occurs with Exporting. Try making a project setting change, then doing an export to iOS. I was pulling my hair out for a few hours (change setting, export, fix Xcode settings, export to phone, repeat.... over and over....) trying to work out why the settings weren't going into my exported iOS project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants