Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphEdit] GraphElement's 'item_rect_changed' signal is not disconnected when leaving tree #94811

Closed
maidopi-usagi opened this issue Jul 26, 2024 · 0 comments · Fixed by #94810
Closed

[GraphEdit] GraphElement's 'item_rect_changed' signal is not disconnected when leaving tree #94811

maidopi-usagi opened this issue Jul 26, 2024 · 0 comments · Fixed by #94810
Labels
bug topic:gui
Milestone
4.3

Comments

@maidopi-usagi
Copy link
Contributor

Tested versions

Repoducible on Godot Engine v4.3.rc1.official

System information

Godot v4.3.rc1.mono - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.4592) - 13th Gen Intel(R) Core(TM) i7-13700F (24 Threads)

Issue description

When a GraphElement removed from SceneTree and added back, will throw errors like these.

image

Steps to reproduce

Open the MRP,
Just press Space or Enter to make a GraphNode in and out, and check the debugger

Minimal reproduction project (MRP)

graphedit_signal_mrp.zip
@maidopi-usagi maidopi-usagi mentioned this issue Jul 26, 2024
Merged
@maidopi-usagi maidopi-usagi changed the title [GraphEdit] GraphElement's 'item_rect_changed' signal not correctly disconnected [GraphEdit] GraphElement's 'item_rect_changed' signal is not disconnected when leaving tree Jul 26, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

[GraphEdit] Correctly disconnect signal to connection_layer maidopi-usagi/godot
2 participants
@maidopi-usagi @AThousandShips