Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MP] RPC visibility-based filtering is missing on server side #96698

Closed
Withaust opened this issue Sep 7, 2024 · 0 comments
Closed

[MP] RPC visibility-based filtering is missing on server side #96698

Withaust opened this issue Sep 7, 2024 · 0 comments

Comments

@Withaust
Copy link
Contributor

Withaust commented Sep 7, 2024

Tested versions

Present in master branch

System information

Does not matter

Issue description

Lets imagine a simple setup in a game where multiple scenes could be used for different levels:

  • Client loads into level 1 and gets level 1 to be set as visible for him
  • Client loads into level 2, gets level 2 to be set visible for him, while level 1 becomes invisible for him
  • Client sends RPC calls to level 1, but since filtering is done on client side, he just ignores it and successfully sends RPC to objects that are supposed to be invisible for him

This is an issue that was there since the visibility introduction, but was never brought up before. Current sender-only visibility filtering is easily circumventable, and additional visibility filtering for RPCs should also be implemented from the server as well.

Steps to reproduce

^^^

Minimal reproduction project (MRP)

...

@Withaust Withaust changed the title [MP] RPC filtering is missing on server side [MP] RPC visibility-based filtering is missing on server side Sep 7, 2024
@Withaust Withaust closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants