Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering properties from #93779 unsets editor set custom properties for [Tool] nodes. #96983

Closed
pmoosi opened this issue Sep 13, 2024 · 3 comments · Fixed by #97014
Closed

Comments

@pmoosi
Copy link

pmoosi commented Sep 13, 2024

Tested versions

System information

Godot v4.4.dev.mono (40d8d82) - Ubuntu 24.04.1 LTS 24.04 - Wayland - Vulkan (Forward+) - integrated AMD Radeon Graphics (RADV RENOIR) - AMD Ryzen 7 5800H with Radeon Graphics (16 Threads)

Issue description

The reordering done by #93779 seems to unset the custom properties set via the editor for [Tool] annotated scripts.

Steps to reproduce

Create some node, attach a C# script with some custom property and annotate it with [Tool].

After building, set the property in the editor. When reloading the scene, it will be unset/set to the default value.

Minimal reproduction project (MRP)

mrp.zip

@AThousandShips

This comment was marked as resolved.

@pmoosi
Copy link
Author

pmoosi commented Sep 14, 2024

Just added one.

@raulsntos
Copy link
Member

Looks like #93779 reintroduced #54414. The script property must always be serialized before all the script's custom properties because, until we reach the script property, custom properties will be unrecognized.

cc @hayahane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Unassessed
3 participants