Tool scripts modified from the in-engine script editor don't update

[SaracenOne]

Tested versions

4542516

System information

Windows 11

Issue description

It seems a recent PR, while intended to fix updating script properties when editing script properties from external editors, caused similar issues when updating scripts from the in-engine editor, including the entire script failing to update, not just the property panel.

The problem seems to actually be specific to tool scripts, and the behaviour is only noticed after a regular script is converted to a tool script and the project is reloaded. After this point, it becomes impossible to update the script. The error Condition "!p_keep_state && has_instances" is true. Returning: ERR_ALREADY_IN_USE is also visible upon saving this script for the first time.

Bisected to a regression in commit 46edd6d

Steps to reproduce

• Open the project and test scene
• In the script assigned the root node, modify the name of the test1 property to something else.
• Save the script and observe the error.
• Click on another node in the scene tree and back to the root node.
• The root node's inspector may have changed, but repeat the step of renaming the exported property once again and observe that the inspector will stop updating, becoming stuck after the first attempt to update it.

Minimal reproduction project (MRP)

gdscript_test.zip

[ryevdokimov]

@Hilderin

Maybe: #97168 will fix the issue, it at least resolves the error.

[Hilderin]

Yes, #97168 will fix the error message and the fact that tool scripts are not reloaded anymore.

[SaracenOne]

Yes, can confirm that that PR does indeed fix this issue.

[SaracenOne]

Closed by #97168