Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverb "Damp" parameter values don't match description. #98945

Open
yosimba2000 opened this issue Nov 8, 2024 · 3 comments · May be fixed by #99222
Open

Reverb "Damp" parameter values don't match description. #98945

yosimba2000 opened this issue Nov 8, 2024 · 3 comments · May be fixed by #99222

Comments

@yosimba2000
Copy link

yosimba2000 commented Nov 8, 2024

Tested versions

Godot 4.3 .Net

System information

Win10 x64 22H2

Issue description

"Damp" parameter says it measures how reflective the reverb is.
0 Damping should imply full reflectivity AKA no damping
1 Damping should imply no reflectivity AKA full damping.

Right now, 0 Damping performs no reflectivity AKA full damping. 1 Damping performs full reflectivity AKA no damping.

Solution: Invert values and keep current description OR keep current values and change Damping to Reflectiveness.

Steps to reproduce

n/a

Minimal reproduction project (MRP)

n/a

@AThousandShips
Copy link
Member

AThousandShips commented Nov 8, 2024

This would have to be changed in the documentation, as changing the behaviour would break compatibility

@AsfarHorani
Copy link

@yosimba2000 can you assign it to me? I am willing to contribute

@AThousandShips
Copy link
Member

Go ahead and make a PR, we don't assign issues to people generally except area maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants