Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 [Feature]: locals accepts interface{} for key #2143

Closed
3 tasks done
pjebs opened this issue Oct 6, 2022 · 2 comments · Fixed by #2144
Closed
3 tasks done

🚀 [Feature]: locals accepts interface{} for key #2143

pjebs opened this issue Oct 6, 2022 · 2 comments · Fixed by #2144
Labels
✏️ Feature 🏷 Wait for Release

Comments

@pjebs
Copy link
Contributor

pjebs commented Oct 6, 2022 •
edited
Loading

Feature Description

Currently Locals accepts only a string for key.

Fasthttp has merged my PR to change uservalues to accept Interface{} for key: valyala/fasthttp#1387 (comment)

Additional Context (optional)

See valyala/fasthttp#1385 (comment)

Code Snippet (optional)

No response

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my suggestion prior to opening this one.
  • I understand that improperly formatted feature requests may be closed without explanation.
@efectn
Copy link
Member

efectn commented Oct 6, 2022

I think we can replace it after new Fasthttp version releases

@pjebs pjebs mentioned this issue Oct 7, 2022
Merged
@pjebs
Copy link
Contributor Author

pjebs commented Oct 7, 2022

@efectn PR complete

@efectn efectn linked a pull request Oct 7, 2022 that will close this issue
- update Locals function to accept interface{} key #2144
Merged
This was referenced Mar 7, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✏️ Feature 🏷 Wait for Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

- update Locals function to accept interface{} key
2 participants
@pjebs @efectn