Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to switch Go standard package 'context' #282

Open
gyuho opened this issue Apr 4, 2017 · 2 comments
Open

Any plan to switch Go standard package 'context' #282

gyuho opened this issue Apr 4, 2017 · 2 comments

Comments

@gyuho
Copy link

gyuho commented Apr 4, 2017

I see this const here https://github.com/gogo/protobuf/blob/master/protoc-gen-gogo/grpc/grpc.go#L56

// Paths for packages used by code generated in this file,
// relative to the import_prefix of the generator.Generator.
const (
	contextPkgPath = "golang.org/x/net/context"
	grpcPkgPath    = "google.golang.org/grpc"
)

When this would be changed to "context"?

Reference

Thanks!

@gyuho gyuho mentioned this issue Apr 4, 2017
26 tasks
@awalterschulze
Copy link
Member

gogoprotobuf is a fork, so as soon as golang/protobuf does this change, we will merge it.
If this is very urgent maybe we can make a different plan?

@gyuho
Copy link
Author

gyuho commented Apr 4, 2017

@awalterschulze Nothing urgent :) We want to wait until golang/protobuf change as well, because that's when grpc-go is going to use context as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants