Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the emoji parsing to pageparser #5534

Closed
bep opened this issue Dec 17, 2018 · 1 comment · Fixed by #5537
Closed

Move the emoji parsing to pageparser #5534

bep opened this issue Dec 17, 2018 · 1 comment · Fixed by #5537
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.53

Comments

@bep
Copy link
Member

bep commented Dec 17, 2018

No description provided.

@bep bep added this to the v0.53 milestone Dec 17, 2018
@bep bep self-assigned this Dec 17, 2018
bep added a commit to bep/hugo that referenced this issue Dec 18, 2018
@bep
parser/pageparser: Split the page lexer into some more files
3c4ce11 
See gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 18, 2018
@bep
Move the emoji parsing to pageparser
c1d8431 
Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 18, 2018
@bep
Move the emoji parsing to pageparser
16261f3 
Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 19, 2018
@bep
Move the emoji parsing to pageparser
5dcc86a 
Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 19, 2018
@bep
parser/pageparser: Split the page lexer into some more files
d46e6f5 
See gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 19, 2018
@bep
Move the emoji parsing to pageparser
544c107 
Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
604faff 
Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
parser/pageparser: Split the page lexer into some more files
0188bfc 
See gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
379a004 
Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
066ab3d 
This avoids double parsing the page content when `enableEmoji=true`.

This commit also adds some general improvements to the parser, making it in general much faster:

```bash
benchmark                     old ns/op     new ns/op     delta
BenchmarkShortcodeLexer-4     91691         103062        +12.40%
BenchmarkParse-4              140583        15364         -89.07%

benchmark                     old allocs     new allocs     delta
BenchmarkShortcodeLexer-4     456            700            +53.51%
BenchmarkParse-4              28             33             +17.86%

benchmark                     old bytes     new bytes     delta
BenchmarkShortcodeLexer-4     69874         81013         +15.94%
BenchmarkParse-4              8128          8304          +2.17%
```

Running some site benchmarks with Emoji support turned on:

```bash

benchmark                                                                                     old ns/op     new ns/op     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     918122675     830462873     -9.55%

benchmark                                                                                     old allocs     new allocs     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     4110409        4146609        +0.88%

benchmark                                                                                     old bytes     new bytes     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     426338996     426098116     -0.06%
```

Fixes gohugoio#5534
@bep bep mentioned this issue Dec 20, 2018
Merged
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
4d27af6 
This avoids double parsing the page content when `enableEmoji=true`.

This commit also adds some general improvements to the parser, making it in general much faster:

```bash
benchmark                     old ns/op     new ns/op     delta
BenchmarkShortcodeLexer-4     90258         101730        +12.71%
BenchmarkParse-4              148940        15037         -89.90%

benchmark                     old allocs     new allocs     delta
BenchmarkShortcodeLexer-4     456            700            +53.51%
BenchmarkParse-4              28             33             +17.86%

benchmark                     old bytes     new bytes     delta
BenchmarkShortcodeLexer-4     69875         81014         +15.94%
BenchmarkParse-4              8128          8304          +2.17%
```

Running some site benchmarks with Emoji support turned on:

```bash
benchmark                                                                           $
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,ren$

benchmark                                                                           $
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,ren$

benchmark                                                                           $
$es,render-4     426982864     424363832     -0.61%
```

Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
a2846ba 
This avoids double parsing the page content when `enableEmoji=true`.

This commit also adds some general improvements to the parser, making it in general much faster:

```bash
benchmark                     old ns/op     new ns/op     delta
BenchmarkShortcodeLexer-4     90258         101730        +12.71%
BenchmarkParse-4              148940        15037         -89.90%

benchmark                     old allocs     new allocs     delta
BenchmarkShortcodeLexer-4     456            700            +53.51%
BenchmarkParse-4              28             33             +17.86%

benchmark                     old bytes     new bytes     delta
BenchmarkShortcodeLexer-4     69875         81014         +15.94%
BenchmarkParse-4              8128          8304          +2.17%
```

Running some site benchmarks with Emoji support turned on:

```bash
benchmark                                                                                     old ns/op     new ns/op     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     924556797     818115620     -11.51%

benchmark                                                                                     old allocs     new allocs     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     4112613        4133787        +0.51%

benchmark                                                                                     old bytes     new bytes     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     426982864     424363832     -0.61%
```

Fixes gohugoio#5534
bep added a commit to bep/hugo that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
0c03a21 
This avoids double parsing the page content when `enableEmoji=true`.

This commit also adds some general improvements to the parser, making it in general much faster:

```bash
benchmark                     old ns/op     new ns/op     delta
BenchmarkShortcodeLexer-4     90258         101730        +12.71%
BenchmarkParse-4              148940        15037         -89.90%

benchmark                     old allocs     new allocs     delta
BenchmarkShortcodeLexer-4     456            700            +53.51%
BenchmarkParse-4              28             33             +17.86%

benchmark                     old bytes     new bytes     delta
BenchmarkShortcodeLexer-4     69875         81014         +15.94%
BenchmarkParse-4              8128          8304          +2.17%
```

Running some site benchmarks with Emoji support turned on:

```bash
benchmark                                                                                     old ns/op     new ns/op     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     924556797     818115620     -11.51%

benchmark                                                                                     old allocs     new allocs     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     4112613        4133787        +0.51%

benchmark                                                                                     old bytes     new bytes     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     426982864     424363832     -0.61%
```

Fixes gohugoio#5534
@bep bep closed this as completed in #5537 Dec 20, 2018
bep added a commit that referenced this issue Dec 20, 2018
@bep
parser/pageparser: Split the page lexer into some more files
a8853f1 
See #5534
bep added a commit that referenced this issue Dec 20, 2018
@bep
Move the emoji parsing to pageparser
9cd54ca 
This avoids double parsing the page content when `enableEmoji=true`.

This commit also adds some general improvements to the parser, making it in general much faster:

```bash
benchmark                     old ns/op     new ns/op     delta
BenchmarkShortcodeLexer-4     90258         101730        +12.71%
BenchmarkParse-4              148940        15037         -89.90%

benchmark                     old allocs     new allocs     delta
BenchmarkShortcodeLexer-4     456            700            +53.51%
BenchmarkParse-4              28             33             +17.86%

benchmark                     old bytes     new bytes     delta
BenchmarkShortcodeLexer-4     69875         81014         +15.94%
BenchmarkParse-4              8128          8304          +2.17%
```

Running some site benchmarks with Emoji support turned on:

```bash
benchmark                                                                                     old ns/op     new ns/op     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     924556797     818115620     -11.51%

benchmark                                                                                     old allocs     new allocs     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     4112613        4133787        +0.51%

benchmark                                                                                     old bytes     new bytes     delta
BenchmarkSiteBuilding/TOML,num_langs=3,num_pages=5000,tags_per_page=5,shortcodes,render-4     426982864     424363832     -0.61%
```

Fixes #5534
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.53
Development

Successfully merging a pull request may close this issue.

Move emoji parsing bep/hugo
1 participant
@bep