Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gopath to point to gojek repo #26

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Jan 2, 2019

From original gojektech repo. Fix for issue #16

@tims
Copy link
Contributor

tims commented Jan 2, 2019

Why is the generated go code checked in?

@zhilingc
Copy link
Collaborator Author

zhilingc commented Jan 2, 2019

Why is the generated go code checked in?

It needs to be checked in so that other go code bases can reference and pull them. Which is necessary since we have a go sdk.

@tims
Copy link
Contributor

tims commented Jan 2, 2019

Ahh ok, go is weird

Copy link
Contributor

@tims tims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pradithya pradithya merged commit 85dba96 into feast-dev:master Jan 2, 2019
@zhilingc zhilingc deleted the gopath-fix branch January 14, 2019 09:42
dmartinol pushed a commit to dmartinol/feast that referenced this pull request Jul 1, 2024
Added filter_only flag to assert_permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants