Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skeleton contributing guide #33

Merged
merged 2 commits into from
Jan 7, 2019
Merged

skeleton contributing guide #33

merged 2 commits into from
Jan 7, 2019

Conversation

tims
Copy link
Contributor

@tims tims commented Jan 3, 2019

Skeleton for #32

@tims
Copy link
Contributor Author

tims commented Jan 3, 2019

@zhilingc anything you want to add for the cli / golang?

@zhilingc
Copy link
Collaborator

zhilingc commented Jan 4, 2019

@zhilingc anything you want to add for the cli / golang?

Not really. Just make sure everything is go fmt'd and the code style follows whatever the golinter prescribes.

@tims
Copy link
Contributor Author

tims commented Jan 6, 2019

/test

@zhilingc I added a note about go. Do you approve?
@woop can you review? Do we still need two separate reviewers now?

I know this contrib file is very sparse, but I think we should start small.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tims

If they are not already assigned, you can assign the PR to them by writing /assign @tims in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jan 7, 2019

/test

@zhilingc I added a note about go. Do you approve?
@woop can you review? Do we still need two separate reviewers now?

I know this contrib file is very sparse, but I think we should start small.

I dont think we need separate reviewers for light weight changes like this. Once you have one reviewer you can merge it.

/lgtm

@tims tims merged commit 7ca0e3f into feast-dev:master Jan 7, 2019
@tims tims deleted the contrib branch January 7, 2019 05:16
dmartinol pushed a commit to dmartinol/feast that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants