Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ui service rpc #9

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Expose ui service rpc #9

merged 3 commits into from
Dec 19, 2018

Conversation

pradithya
Copy link
Collaborator

Expose gRPC services declared in UIService.proto. These services provide detailed information about Feast's resources (feature, entity, and storage) that can be used by either CLI or SDK.

Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/src/main/java/feast/core/grpc/UIServiceImpl.java Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhilingc zhilingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhilingc zhilingc merged commit 8707c3a into master Dec 19, 2018
@zhilingc zhilingc deleted the expose_ui_service_rpc branch December 19, 2018 02:29
dmartinol pushed a commit to dmartinol/feast that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants