-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Equivalent of Range's set draw_borders separators
setting
#1438
Comments
@wincent That sounds quite reasonable. However, we should probably figure out a way to do this without a breaking change if possible. It is unfortunate that I didn't realize ranger's Beyond the details of the option, I don't expect the implementation of this feature to be much difficult. So if anyone wants to give this a try, feel free to do so. I don't have much free time myself these days. |
Follows the pattern established by Ranger's `draw_borders` setting: - `true` / `both`: draw an outline box around all panes, plus vertical separators between panes. - `outline`: draw only the outline box. - `separators`: draw only the separators. - `false` / `none`: draw neither outline box nor separators (default). So, this is a string option that accepts "true" and "false" strings for backwards compatibility. Note the behavior of toggling with `:set drawbox!`: if any borders are being drawn (ie. "both", "outline" or "separators", turns them off; if no borders are being drawn (ie. "none"), turns them all on (ie. "both"). Closes: gokcehan#1438
@gokcehan I sent a PR with a possible implementation here. Lightly tested it and it seems to work.
I'm not sure if this is a problem. |
@wincent Thank you very much for the PR. That approach could work, but isn't it a little confusing that |
Ok, so how about this:
With the new setting, you could get equivalent of the ranger settings with:
People would be able to use other combinations that Ranger doesn't support either, if they wanted 🤷🏻 — eg. We could optionally add Obviously, all of those names are just ideas and up for discussion. If you have a clear idea of what names you'd want, I can take a stab at rolling an updated PR. Footnotes
|
@wincent That sounds like a good plan to me. We can also call the new option simply
I think maybe midnight commander has such a layout for its bottom line so I thought maybe someone can request it in the future. In any case, this is not something that needs to be implemented in this patch. I just thought it could be nice to leave it as a possibility for the future. Apart from that, I don't see much benefit in having fine grained controls at the moment, so you might as well just leave the patch as it is with only two cases (e.g.
If we decide to add I think it is a good idea to leave this issue/PR open for a while for possible feedback from others. You may or may not want to update your patch in the meantime as you wish. Note, I will not be available next week, but we have other contributors who can merge the patch when I'm not around. I'm generally okay with whatever decision comes out from this discussion. |
I took a look at the patch as well, some thoughts from me:
|
In Ranger, you can get it to draw separators only between the columns.
lf has the comparable
set drawbox
setting, but it draws borders around all edges, including the top and bottom ones.Could we please have a setting to draw only separators? That would free up two lines (one at top, one at bottom) and two columns (one at far left, one at far right), which is useful given limited screen real estate.
The text was updated successfully, but these errors were encountered: