Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chafa symbol preview error #1736

Closed
pzant opened this issue Jun 1, 2024 · 9 comments · Fixed by #1737
Closed

Chafa symbol preview error #1736

pzant opened this issue Jun 1, 2024 · 9 comments · Fixed by #1737

Comments

@pzant
Copy link

pzant commented Jun 1, 2024

Some pictures (usually big) previewed in a big or fullscreen using chafa -а symbols lose and become distorted at the end of lines.
For example with this picture:
break lines

@joelim-work
Copy link
Collaborator

Thanks for the bug report. Can you try #1737 to see if this works for you?

@pzant
Copy link
Author

pzant commented Jun 2, 2024

Thanks for the bug report. Can you try #1737 to see if this works for you?

I'm initially using chafa --polite on -f symbols -s "${2}x{3}" "$1"

@joelim-work
Copy link
Collaborator

BTW you didn't answer my question, could you please confirm if the PR actually works for you?

@pzant
Copy link
Author

pzant commented Jun 3, 2024

This shows a preview but with the errors described in the first post.

@joelim-work
Copy link
Collaborator

Strange, the changes in the PR fixes the issue for me. Unless I fixed a different bug.

In that case I don't know what your issue is, unless you provide a screen recording or something containing more detail.

@pzant
Copy link
Author

pzant commented Jun 3, 2024

alacritty
foot
It looks like this in alacritty and foot.

@joelim-work
Copy link
Collaborator

Yeah, that's the same issue I have (the top half):
image

The bottom half is after my change. Did you actually checkout the PR branch and build it?

@pzant
Copy link
Author

pzant commented Jun 3, 2024

Sorry. I made a mistake. Yes, your PR fixes the problem.

@joelim-work
Copy link
Collaborator

Thanks for confirming, I will go ahead and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants