Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.FileSystem source #307

Closed
wayneashleyberry opened this issue Nov 23, 2019 · 8 comments
Closed

http.FileSystem source #307

wayneashleyberry opened this issue Nov 23, 2019 · 8 comments

Comments

@wayneashleyberry
Copy link

wayneashleyberry commented Nov 23, 2019

There are 3 open pull requests adding an http.FileSystem migration source, any chance we could prioritise one of them and all put our efforts in the same place?

I'd really like to help get one of these merged, if at all possible. I want to start using this library with pkger, so if there's anything I can do to help please let me know.

@philipjscott
Copy link

I've seen issues and PRs discussing http.FileSystem that are more than half a year old:

I really hope the community agrees upon a PR and gets something merged, but I don't think anything is going to happen unless maintainers start communicating.

I'd really like to see support for http.FileSystem; please let me know if there's any way I can help 😄

@fschade
Copy link

fschade commented Dec 2, 2019

+1, if help needed...

@philipjscott
Copy link

@dhui can you please share your thoughts on this situation?

Out of the three open PRs, which implementation do you like the best? If we polished it up, would you be okay with merging it?

@Ambyjkl
Copy link

Ambyjkl commented Dec 5, 2019

+1

@dhui
Copy link
Member

dhui commented Dec 11, 2019

Current status of PRs

#144 needs to be refactored
#163 has the best design but its tests need to be updated to not use temp directories
#293 should adopt a similar design pattern to #163

I'm happy to merge any of those PRs if the issues are addressed. #163 and #293 seem the closest

@dhui
Copy link
Member

dhui commented Dec 24, 2019

#293 has been merged to master. Will cut a new release after it's been in master for a bit

@dhui
Copy link
Member

dhui commented Jan 13, 2020

Now available in v4.8.0

@dhui dhui closed this as completed Jan 13, 2020
@wayneashleyberry
Copy link
Author

Fantastic, thanks for keeping us in the loop @dhui 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants