From b0355a3e72df384c82a688524c603a97c1d8e7a7 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Thu, 10 Jun 2021 15:14:01 -0400 Subject: [PATCH] time: fix receiver for Time.IsDST method Only methods that modify the time take pointer receivers; IsDST does not modify it and therefore should not. For #42102 and #46688. Change-Id: I4721ef7f4d7572236ae6e4d99a459b9ffb11999e Reviewed-on: https://go-review.googlesource.com/c/go/+/326789 Trust: Russ Cox Run-TryBot: Russ Cox TryBot-Result: Go Bot Reviewed-by: Dmitri Shuralyov Reviewed-by: Ian Lance Taylor --- api/go1.17.txt | 2 +- src/time/time.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/go1.17.txt b/api/go1.17.txt index f054458715fb0..257ca271d3dac 100644 --- a/api/go1.17.txt +++ b/api/go1.17.txt @@ -153,7 +153,7 @@ pkg time, const Layout = "01/02 03:04:05PM '06 -0700" pkg time, const Layout ideal-string pkg time, func UnixMicro(int64) Time pkg time, func UnixMilli(int64) Time -pkg time, method (*Time) IsDST() bool +pkg time, method (Time) IsDST() bool pkg time, method (Time) GoString() string pkg time, method (Time) UnixMicro() int64 pkg time, method (Time) UnixMilli() int64 diff --git a/src/time/time.go b/src/time/time.go index cd756bbf5f28b..1cf1e2bbf61f2 100644 --- a/src/time/time.go +++ b/src/time/time.go @@ -1340,7 +1340,7 @@ func UnixMicro(usec int64) Time { } // IsDST reports whether the time in the configured location is in Daylight Savings Time. -func (t *Time) IsDST() bool { +func (t Time) IsDST() bool { _, _, _, _, isDST := t.loc.lookup(t.Unix()) return isDST }