Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/time/rate: inconsistent behaviour of rate.Limiter.WaitN #16854

Closed
perillo opened this issue Aug 23, 2016 · 1 comment
Closed

x/time/rate: inconsistent behaviour of rate.Limiter.WaitN #16854

perillo opened this issue Aug 23, 2016 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@perillo
Copy link
Contributor

perillo commented Aug 23, 2016

The documentation of rate.Limiter.WaitN function says that it blocks until lim permits n events to happen and that it returns an error if n exceeds the Limiter's burst size.

However the documentation of rate.Limiter type says that, as a special case, if rate limit is Inf, burst size is ignored.
@ianlancetaylor
Copy link
Contributor

CC @Sajmani

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Aug 23, 2016
@golang golang locked and limited conversation to collaborators Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @perillo @gopherbot