Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar for go get command #18388

Closed
rishiloyola opened this issue Dec 20, 2016 · 5 comments
Closed

Add progress bar for go get command #18388

rishiloyola opened this issue Dec 20, 2016 · 5 comments

Comments

@rishiloyola
Copy link

It would be good to have a bar on terminal showing progress of package downloading process.

@rishiloyola rishiloyola changed the title Progress bar for go get command Add progress bar for go get command Dec 20, 2016
@ALTree
Copy link
Member

ALTree commented Dec 20, 2016

#17959 was about adding some kind of feedback/output (possibly a progress bar) to go get. It was rejected. Note that you can use -v to make get a little more verbose.

@bradfitz
Copy link
Contributor

Yeah, dup of #17959

I personally think it would be okay to play terminal-detection games and only do a curses progress UI if the terminal supports such things, but the Go tools are pretty opinionated against terminals, ASCII art, and color, so I don't see this happening.

I recommend somebody prototype this first as an external tool (you could run go get -v as a child process and parse its output for the prototype?), and get a demo ready. If the demo is convincing and people like it, I'd support it, but I don't think anybody on the Go team has time to work on this itself.

I'd say come back with code, with the understanding that it might be fated to live out of tree.

@rishiloyola
Copy link
Author

@bradfitz I guess we don't need any kind of fancy stuff. It will be just simple bar.
Let me implement it.

@bradfitz
Copy link
Contributor

Prototype away.

@minux
Copy link
Member

minux commented Dec 21, 2016 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants