Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: GC can thrash on very small heaps #22743

Closed
aclements opened this issue Nov 15, 2017 · 3 comments
Closed

runtime: GC can thrash on very small heaps #22743

aclements opened this issue Nov 15, 2017 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Performance
Milestone

Comments

@aclements
Copy link
Member

In applications with very small heaps and high allocation rates, the garbage collector can consume a large amount of CPU by running very frequently. This particularly affects microbenchmarks, which often have virtually no live heap, causing a full GC cycle every 4MB of allocation. We've seen this several times, and Cloudflare just blogged about this problem: https://blog.cloudflare.com/go-dont-collect-my-garbage/

We should consider rate-limiting the garbage collector, allowing the heap to grow beyond the goal if the GC is running too frequently or using too much CPU. We could potentially replace the (rather arbitrary) 4MB lower-bound on heap size with a more principled rate-limiting system.

One possible approach is to enforce an upper bound on GC utilization. This could be measured GC CPU overhead (e.g., MemStats.GCCPUFraction) or simply the ratio of GC active wall-clock time to total wall-clock time. The GC trigger would be delayed until this metric drops below the upper bound. This should prevent thrashing.

With this approach, we could also enforce a lower bound, which could be a more principled replacement for the current 2 minute forced GC. This should prevent starvation.

@RLH and I have talked about this several times, but apparently neither of us filed an issue to track it. I'm correcting that. :)

@aclements aclements added this to the Go1.11 milestone Nov 15, 2017
@aclements aclements changed the title runtime: consider rate-limiting GC runtime: GC can thrash on very small heaps Nov 15, 2017
@bradfitz bradfitz modified the milestones: Go1.11, Go1.12 Jun 20, 2018
@aclements
Copy link
Member Author

The actual problem here is that we fail to amortize the cost of GC on small heaps. I've detailed the problem in #23044 (comment).

@aclements aclements modified the milestones: Go1.12, Go1.13 Dec 18, 2018
@aclements aclements modified the milestones: Go1.13, Go1.14 Jun 25, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@mknyszek mknyszek moved this to Triage Backlog in Go Compiler / Runtime Jul 15, 2022
@prattmic
Copy link
Member

@mknyszek do we want to do more here?

@mknyszek
Copy link
Contributor

I don't think so. While the pacer doesn't really model some GC fixed costs and things can still get weird when these fixed costs dominate, the Go 1.18 pacer also pushed this problem back enough that I'm comfortable not doing anything else here for now and calling it good.

Repository owner moved this from Triage Backlog to Done in Go Compiler / Runtime Aug 18, 2022
@golang golang locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Performance
Projects
None yet
Development

No branches or pull requests

6 participants