go/build: doesn't implement new GO111MODULE=auto logic for 1.13 #32799
Labels
FrozenDueToAge
modules
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Milestone
There was limited module support added to
go/build
in #26504.There is logic to determine whether it's appropriate to look at modules in
Context.importGo
method:(Source: src/go/build/build.go#L1004-L1019)
This logic is out of date for 1.13 given the change to
GO111MODULE=auto
in #31857.Further below, it looks to see if there is a go.mod file in the source directory or any of its parent directories. That needs to be checked before
return errNoModules
can be done whensrcDir
is inside GOPATH/src.I know the support for modules in
go/build
is limited, so we need to decide if we should fix this or not. Given that having the wrong logic here can produce incorrect/inconsistent results and the fix should be small, I think it makes sense to do it. Added NeedsDecision label./cc @bcmills @jayconrod @rsc @matloob
The text was updated successfully, but these errors were encountered: