-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: crypto/cipher: Specify nonce and tag sizes for GCM #34594
Comments
It appears that this was done on purpose. Look at 33f1768: it renamed Neither the commit message nor the issue it fixes (#24977) seem to give a rationale for the change, except for a small comment by @rsc on the issue, which says:
Moreover, in #24171 (comment), rsc wrote:
Overall, it seems that the limitation of not being able to set the nonce size is intentional. cc @FiloSottile |
I guess it feels weird to offer two different options but not the composition of both, especially since they're only there for compatibility reasons. It would make sense if both helpers had a major use case for development, but they're meant to be used reluctantly. |
Is there any protocol that requires a custom tag and nonce size? |
Adding to proposal minutes, seems headed for likely decline. |
Based on the discussion above, this is a likely decline. |
No change in consensus, so declined. |
Is there any reason for why NewGCM, NewGCMWithNonceSize, and NewGCMWithTagSize are public while newGCMWithNonceAndTagSize isn't? Unless I'm missing something, creating an AEAD with custom sizes for both nonce and tag seems impossible.
So the proposal would be to transform newGCMWithNonceAndTagSize -> NewGCMWithNonceAndTagSize.
The text was updated successfully, but these errors were encountered: