x/build/cmd/gopherbot: make decision on whether anyone can add/remove release-blocker without specifying reason

[dmitshur]

gopherbot removed the release-blocker label in #35482 (comment).

Need to investigate and understand why it happened.

[cespare]

I believe that @zx2c4 asked gopherbot to remove the label. Then maybe he deleted his own comment?

[ALTree]

Shouldn't the gopherbot only process "please add label" comments from the issue creator?

It seems weird that a user that 1) is not the OP of the issue 2) has no "add/remove label" permission on the repository, can ask gopherbot to remove labels.

[dmitshur]

Thanks @cespare, that's very helpful.

The intention is for gopherbot to allow anyone to add or remove labels, as described at https://golang.org/wiki/gopherbot. There are some labels that are not allowed to be added/removed (see here).

We may want to rethink this interaction for release-blocker labels. /cc @golang/osp-team

[networkimprov]

I'm the OP of that issue, and set the original release-blocker via gopherbot.

Since there's now the Backlog milestone, maybe anything milestoned for a release is effectively a release-blocker? Still, it's nice to see the big red flag in issue lists.

Tangentially, it's difficult/impossible to add the "help wanted" label via gopherbot, due to the space character. Maybe that could be renamed.

[zx2c4]

gopherbot removed the release-blocker label in #35482 (comment).

Need to investigate and understand why it happened.

I asked gopherbot to do this.

[dmitshur]

Thanks @zx2c4. I made #35757 about finding a way to improve it so that it's more clear when that happens. I left a comment on the original issue to give you more context on why we re-added the label.

Tangentially, it's difficult/impossible to add the "help wanted" label via gopherbot, due to the space character. Maybe that could be renamed.

@networkimprov Have you seen https://golang.org/wiki/gopherbot#addingremoving-labels? It describes how to work with labels containing spaces, using "help wanted" as an example. Please open a new issue about it if there is a problem.

[networkimprov]

Testing... (I remember trying these before, without success, hm)

EDIT: Well the add variants of these commands worked, but not remove!

@gopherbot remove help wanted
@gopherbot remove OS-Windows, OS-Linux

EDIT: try add via edit
@gopherbot add OS-Linux

[dmitshur]

I don't think editing an existing comment is supported. Let me try a new comment.

@gopherbot remove help wanted
@gopherbot remove OS-Windows, OS-Linux