testing: t.FailNow should panic if called from wrong goroutine

[gopherbot]

by dawagner:

I expect testing.T.FailNow() to cleanly fail a test, including terminating any running
goroutines, and the main routine if it was called in a goroutine.

Running `go test` with the attached file, I expect to see "I'm about to fail",
followed by the test cleanly failing.

Instead I see:
$ go test
I'm about to fail
I'm about to loop forever

and the process never terminates.

This also happens if the infinite loop is in the main thread.
If rather than looping forever, a channel is being waited on, I get a deadlock panic.
If I remove the time.Sleep from the test, the test will pass, and then loop forever!

Which operating system are you using?
Mac OSX 10.6.8 x64

Which version are you using?  (run 'go version')
$ go version
go version go1.0.2

Attachments:

1. bug_test.go (292 bytes)

[minux]

Comment 1:

i don't think it is pkg testing's responsibility to kill all goroutines (maybe they are
useful anyway)
when a test fails
and the test itself is supposed to manage its goroutines.

[rsc]

Comment 3:

t.FailNow is an error if called from a different goroutine. That should be documented
well. Also, it would be great if t.FailNow could panic in that case. However, I am not
sure we can catch that.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[rsc]

Comment 4:

Labels changed: added go1.1.

[rsc]

Comment 5:

Labels changed: added size-m.

[rsc]

Comment 6:

This issue was closed by revision 2cb8dce.

Status changed to Fixed.