Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data #4295

Closed
jmhodges opened this issue Oct 27, 2012 · 5 comments
Closed

x/net/spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data #4295

jmhodges opened this issue Oct 27, 2012 · 5 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@jmhodges
Copy link
Contributor 

As of af69687727e7, the spdy library doesn't support turning off header compression. The
variable headerCompressionDisabled does exist on spdy.Framer, but it's just not exposed.

It also seems that some code for detecting when compression should not be used in the
reader. I can get the ReadFrame method to crash on uncompressed data.
@davecheney
Copy link
Contributor

Comment 1:

Removing the go 1.1 tag.

Labels changed: removed go1.1.

@rsc
Copy link
Contributor

rsc commented Dec 30, 2012

Comment 2:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 3:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-net.

@mikioh mikioh changed the title go.net/spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data x/net/spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data Dec 23, 2014
@mikioh mikioh changed the title x/net/spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data Jan 4, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data x/net/spdy: spdy doesn't expose headerCompressionDisabled and crashes on uncompressed data Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-net label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@jmhodges @davecheney @rsc @gopherbot