Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: add clean commands to clear away potentially corrupt files in module cache #43313

Open
matloob opened this issue Dec 22, 2020 · 2 comments
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@matloob
Copy link
Contributor

matloob commented Dec 22, 2020

cc @bcmills @jayconrod

It's possible under some rare circumstances (a system crash or loss of power during a write) for corrupt files to be written to the module cache. We should add commands to help clear away these corrupt files if they exist so that those serving a GOPROXY from their module cache can have more certainty that they're serving good data.

Two potential commands we discussed are
(1) go clean for a single module, to remove modules suspected of being corrupted
(2) go mod verify -clean to remove module versions that fail checksums

@bcmills
Copy link
Contributor

bcmills commented Dec 22, 2020

Possibly a duplicate of #32976 (CC @hyangah)?

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 22, 2020
@cagedmantis cagedmantis added this to the Backlog milestone Dec 22, 2020
@seankhliao
Copy link
Member

related #28835 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants