Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln: TestStaticCheck failures #68078

Closed
gopherbot opened this issue Jun 19, 2024 · 4 comments
Closed

x/vuln: TestStaticCheck failures #68078

gopherbot opened this issue Jun 19, 2024 · 4 comments
Assignees
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestStaticCheck
    all_test.go:88: /Volumes/Work/s/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc00191c000)
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc000719380, {0x76a7618?, 0xc000c22fa0})
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0x76a7618, 0xc000c22fa0}, {0x76a7618?, 0xc000c22f00?}, 0xc00103afc0, 0xc0001b9510, 0xc001803270)
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 228
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (10.83s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 19, 2024
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Jun 19, 2024
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Jun 19, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-05-15 18:35 x_vuln-gotip-darwin-amd64-longtest vuln@7ed0faae go@bf0b605d x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /Volumes/Work/s/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc00191c000)
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc000719380, {0x76a7618?, 0xc000c22fa0})
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0x76a7618, 0xc000c22fa0}, {0x76a7618?, 0xc000c22f00?}, 0xc00103afc0, 0xc0001b9510, 0xc001803270)
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 228
        	/Volumes/Work/s/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (10.83s)
2024-05-15 18:35 x_vuln-gotip-linux-amd64-longtest vuln@7ed0faae go@bf0b605d x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc0007702d0)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc0010c36b0, {0xa4b258?, 0xc000486640})
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0xa4b258, 0xc000486640}, {0xa4b258?, 0xc0004865a0?}, 0xc000879260, 0xc000401c60, 0xc00144a590)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 365
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (4.97s)
2024-05-15 18:35 x_vuln-gotip-linux-amd64-longtest-race vuln@7ed0faae go@bf0b605d x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc000ba4000)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc000f88900, {0xa4b258?, 0xc0002b2f00})
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0xa4b258, 0xc0002b2f00}, {0xa4b258?, 0xc0002b2820?}, 0xc00118cfc0, 0xc000451b90, 0xc00023e170)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 126
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (12.42s)
2024-05-15 19:10 x_vuln-gotip-darwin-amd64-longtest vuln@7b455eea go@3bcefa52 x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/lintcmd/runner.(*subrunner).do(0xc0000a1090, {0x40f4be0?, 0xc000149c20})
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:577 +0x908
        honnef.co/go/tools/lintcmd/runner.(*Runner).Run.func2({0x40f4be0?, 0xc000149c20?})
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1268 +0x2a
        honnef.co/go/tools/lintcmd/runner.genericHandle({0x40f4be0, 0xc000149c20}, {0x40f4be0?, 0xc000262900?}, 0xc0007ba850, 0xc0003f4190, 0xc000602440)
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*Runner).Run in goroutine 1
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1267 +0x4f4
        exit status 2
--- FAIL: TestStaticCheck (19.66s)
2024-05-15 19:10 x_vuln-gotip-linux-amd64-longtest vuln@7b455eea go@64386585 x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc000d32000)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc000844210, {0xa4d298?, 0xc000327720})
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0xa4d298, 0xc000327720}, {0xa4d298?, 0xc000327680?}, 0xc000f90d20, 0xc000468e90, 0xc000f96cd0)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 332
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (5.68s)
2024-05-15 19:10 x_vuln-gotip-linux-amd64-longtest-race vuln@7b455eea go@64386585 x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc0007224b0)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc0011c7e00, {0xa4d298?, 0xc000e10280})
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0xa4d298, 0xc000e10280}, {0xa4d298?, 0xc000e101e0?}, 0xc000e25420, 0xc00040aa80, 0xc001556c20)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 153
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (16.44s)
2024-05-21 21:02 x_vuln-gotip-darwin-amd64-longtest vuln@6b0fd560 go@5a9dabc2 x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/lintcmd/runner.(*subrunner).do(0xc0001d0eb0, {0x674dbe0?, 0xc00028f320})
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:577 +0x908
        honnef.co/go/tools/lintcmd/runner.(*Runner).Run.func2({0x674dbe0?, 0xc00028f320?})
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1268 +0x2a
        honnef.co/go/tools/lintcmd/runner.genericHandle({0x674dbe0, 0xc00028f320}, {0x674dbe0?, 0xc0003ba360?}, 0xc000589dc0, 0xc0003d3b90, 0xc000378010)
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*Runner).Run in goroutine 1
        	/Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1267 +0x4f4
        exit status 2
--- FAIL: TestStaticCheck (24.27s)
2024-05-21 21:02 x_vuln-gotip-linux-amd64-longtest vuln@6b0fd560 go@5a9dabc2 x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc000672000)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc0008b1b60, {0xa4d298?, 0xc000ba1220})
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0xa4d298, 0xc000ba1220}, {0xa4d298?, 0xc000ba1180?}, 0xc0008b3b20, 0xc000457370, 0xc000fe6410)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 354
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (5.11s)
2024-05-21 21:02 x_vuln-gotip-linux-amd64-longtest-race vuln@6b0fd560 go@5a9dabc2 x/vuln.TestStaticCheck (log)
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        panic: Cannot range over: func(yield func(E) bool)
        
...
        honnef.co/go/tools/internal/passes/buildir.run(0xc0006be0f0)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/internal/passes/buildir/buildir.go:86 +0x18b
        honnef.co/go/tools/lintcmd/runner.(*analyzerRunner).do(0xc000281410, {0xa4d298?, 0xc0000c5540})
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:992 +0x71b
        honnef.co/go/tools/lintcmd/runner.genericHandle({0xa4d298, 0xc0000c5540}, {0xa4d298?, 0xc0000c54a0?}, 0xc0007fde30, 0xc000465ac0, 0xc0002839e0)
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:817 +0x11f
        created by honnef.co/go/tools/lintcmd/runner.(*subrunner).runAnalyzers in goroutine 420
        	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/honnef.co/go/tools@v0.4.3/lintcmd/runner/runner.go:1061 +0x6a6
        exit status 2
--- FAIL: TestStaticCheck (12.18s)

watchflakes

@hyangah
Copy link
Contributor

hyangah commented Jun 21, 2024

Need to update staticcheck (built from master or disable the test until the official release)
dominikh/go-tools#1494

@zpavlinovic
Copy link
Contributor

We have removed this unit test. Closing.

@zpavlinovic zpavlinovic self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Archived in project
Development

No branches or pull requests

4 participants