Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: disable showing global variables by default #138

Closed
ramya-rao-a opened this issue May 29, 2020 · 3 comments
Closed

debug: disable showing global variables by default #138

ramya-rao-a opened this issue May 29, 2020 · 3 comments
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge

Comments

@ramya-rao-a
Copy link
Contributor

As being discussed in microsoft/vscode-go#2210, the feature of showing global variables when debugging requires calling ListPackageVars which is expensive in many cases. The setting showGlobalVariables was introduced for the very same reason of this feature being expensive.

This issue is to consider this setting to have the default value of false instead of true to improve the out of the box experience.

@stamblerre stamblerre added the Debug Issues related to the debugging functionality of the extension. label May 29, 2020
@stamblerre stamblerre changed the title Show global variables when debugging should be disabled by default to improve perf debug: disable showing global variables by default Jun 3, 2020
@hyangah
Copy link
Contributor

hyangah commented Aug 18, 2020

@polinasok Since you are currently looking into the variables listing - what do you think about disabling this by default in the next release? The original issue had ~39 upvotes. I am leaning toward to accepting this.

I'd feel more comfortable if users can turn on/off the global variable listing on demand. Are you aware of any knobs that dynamically control the scope of variables in an active session?

@hyangah hyangah added this to the Backlog milestone Aug 18, 2020
@polinasok
Copy link
Contributor

There is no option currently to control this dynamically. We could create such an option, so variables are loaded only if the user expands the Global scope (which is like a made-up variable in the backend). It could be handled similarly to how we would autoload more variable data that was not loaded right away (this is already done for interfaces, but not other data in vscode-go).

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/251264 mentions this issue: package.json: disable debug config's showGlobalVariables by default

@golang golang locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

5 participants