debugAdapter: add tests for remote attach scenarios #790

quoctruong · 2020-10-15T04:32:24Z

Fixes #779 by:

A test program that spins up a server at http://localhost:8080 to return helloworld.
Adding 4 remote attach tests:

Attaching to a headless instance of Delve running the program. This tests that the initialization sequence up to configuration done request is good.
Attaching with a breakpoint already set. This tests that the breakpoint is hit when we hit the program's URL.
Attaching without any breakpoint and set the breakpoint afterwards. This tests that the breakpoint is hit when we hit the program's URL.
Test that the program still runs after we disconnect from it.

gopherbot · 2020-10-15T04:36:18Z

This PR (HEAD: f115622) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-15T14:51:14Z

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T14:53:13Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4717a7b9-47f4-48e6-b73f-20df37deebd0

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T15:01:26Z

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/4717a7b9-47f4-48e6-b73f-20df37deebd0

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T15:09:22Z

Message from Suzy Mueller:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T16:55:42Z

This PR (HEAD: 22b5458) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-15T16:59:28Z

Message from Quoc Truong:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T17:03:18Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/90e2b41a-8162-4579-89ee-044750261209

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T17:09:44Z

Message from kokoro:

Patch Set 2: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/90e2b41a-8162-4579-89ee-044750261209

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T21:13:38Z

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-16T15:40:00Z

This PR (HEAD: 207d3fa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-16T15:43:49Z

Message from Quoc Truong:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-16T15:47:35Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b10b65e3-3d13-4bb1-81a6-fc2a899a6996

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-16T15:55:10Z

Message from kokoro:

Patch Set 3: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b10b65e3-3d13-4bb1-81a6-fc2a899a6996

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-16T20:16:48Z

This PR (HEAD: 8c0015f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-16T20:36:09Z

Message from Suzy Mueller:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-16T20:40:06Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/88170916-fdfb-4d48-916b-460191331d02

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-16T20:43:51Z

Message from kokoro:

Patch Set 4: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/88170916-fdfb-4d48-916b-460191331d02

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

…ode-go into quoct/remote_test

gopherbot · 2020-10-23T21:05:30Z

This PR (HEAD: 4585e9a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-23T21:09:15Z

Message from Quoc Truong:

Patch Set 10: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-23T21:09:16Z

Message from kokoro:

Patch Set 8: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/57c68b3a-5a17-49e5-82d4-2ce3b09cd03c

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-23T21:14:45Z

Message from kokoro:

Patch Set 10:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/18724021-dd38-4662-8573-0e64f9c8f523

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-24T00:14:30Z

Message from kokoro:

Patch Set 10: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/18724021-dd38-4662-8573-0e64f9c8f523

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T08:26:03Z

Message from Polina Sokolova:

Patch Set 10:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T15:47:35Z

Message from Suzy Mueller:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T16:05:01Z

This PR (HEAD: a0d0b06) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-28T16:08:56Z

Message from Quoc Truong:

Patch Set 11: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T16:18:26Z

Message from kokoro:

Patch Set 11:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/f92551ef-b2ea-4f03-b385-6a591b8f4f43

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T19:15:26Z

Message from kokoro:

Patch Set 11: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/f92551ef-b2ea-4f03-b385-6a591b8f4f43

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T19:24:56Z

Message from Polina Sokolova:

Patch Set 11: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:07:36Z

This PR (HEAD: 3f1965d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-28T21:11:13Z

Message from Quoc Truong:

Patch Set 12: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:15:02Z

Message from kokoro:

Patch Set 12:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/5e596e91-a555-4d83-9e33-1eba1d1ad9d7

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:21:00Z

Message from Hyang-Ah Hana Kim:

Patch Set 12:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:21:01Z

Message from kokoro:

Patch Set 12: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/5e596e91-a555-4d83-9e33-1eba1d1ad9d7

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:34:20Z

Message from Suzy Mueller:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T02:38:33Z

This PR (HEAD: d5057c8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/262442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-03T02:42:10Z

Message from Quoc Truong:

Patch Set 13: Run-TryBot+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T02:47:28Z

Message from kokoro:

Patch Set 13:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/ccecaffb-72dd-4db8-9cb9-529419ec2d59

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T02:51:05Z

Message from kokoro:

Patch Set 13: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/ccecaffb-72dd-4db8-9cb9-529419ec2d59

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-03T14:35:52Z

Message from Hyang-Ah Hana Kim:

Patch Set 13: Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/262442.
After addressing review feedback, remember to publish your drafts!

Fixes #779 by: - A test program that spins up a server at `http://localhost:8080` to return helloworld. - Adding 4 remote attach tests: 1. Attaching to a headless instance of Delve running the program. This tests that the initialization sequence up to configuration done request is good. 2. Attaching with a breakpoint already set. This tests that the breakpoint is hit when we hit the program's URL. 3. Attaching without any breakpoint and set the breakpoint afterwards. This tests that the breakpoint is hit when we hit the program's URL. 4. Test that the program still runs after we disconnect from it. Change-Id: Id7fd8231dafa980304af5325cf9dd5a40df07a0b GitHub-Last-Rev: d5057c8 GitHub-Pull-Request: #790 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/262442 Run-TryBot: Quoc Truong <quoct@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Polina Sokolova <polina@google.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>

gopherbot · 2020-11-03T16:49:23Z

This PR is being closed because golang.org/cl/262442 has been merged.

quoctruong added 4 commits October 14, 2020 11:29

Initial remote scratch

6da5ef0

Add breakpoints tests

eb46ac0

Add disconnect tests

d522f8e

Clean up console.log statements

f115622

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 15, 2020

Add logging for test

22b5458

Fix kill switch

207d3fa

Use treekill

8c0015f

suzmue added 4 commits October 19, 2020 14:27

update long test

087424c

test killProcessTree

c236da8

extend timeout and disconnect before

0f29cf4

remove only

d151dea

Merge branch 'quoct/remote_test' of https://github.com/quoctruong/vsc…

4585e9a

…ode-go into quoct/remote_test

Remove duplicated test

a0d0b06

Merge branch 'master' into quoct/remote_test

3f1965d

Clean up

d5057c8

gopherbot closed this Nov 3, 2020

debugAdapter: add tests for remote attach scenarios #790

debugAdapter: add tests for remote attach scenarios #790

Conversation

quoctruong commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 16, 2020

gopherbot commented Oct 23, 2020

gopherbot commented Oct 23, 2020

gopherbot commented Oct 23, 2020

gopherbot commented Oct 23, 2020

gopherbot commented Oct 24, 2020

gopherbot commented Oct 27, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Nov 3, 2020

gopherbot commented Nov 3, 2020

gopherbot commented Nov 3, 2020

gopherbot commented Nov 3, 2020

gopherbot commented Nov 3, 2020

gopherbot commented Nov 3, 2020