Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: debugAdapter2 must accurately communicate dlv-dap capabilities #844

Closed
polinasok opened this issue Oct 27, 2020 · 1 comment
Closed
Assignees
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone

Comments

@polinasok
Copy link
Contributor

This is branching out from #781, which, in addition to support in debugAdapter, requested that 'supportsConditionalBreakpoints' is correctly reflected in debugAdapter2 as well. This is the only capability right now that is not captured, but there will be more going forward. Simply flipping the bit as soon as the related change is made in the delve repo won't work because by default users work with a stable version of delve. To have an accurate reflection of the capabilities, we can:

@polinasok polinasok added Debug Issues related to the debugging functionality of the extension. DelveDAP labels Oct 27, 2020
@polinasok polinasok changed the title debug: debugAdapter2 must accurately communicate capabilities that dlv dap supports debug: debugAdapter2 must accurately communicate dlv-dap capabilities Oct 27, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/290449 mentions this issue: src/debugAdapter2: remove thin adapter for dlv-dap

@hyangah hyangah added this to the v0.23.0 milestone Mar 2, 2021
@golang golang locked and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

4 participants