Add "revive" linter #1729
Merged
Add "revive" linter #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Hello, could you rebase your PR? thank you |
added 2 commits
February 11, 2021 10:06
Assume disabled by default
ldez
requested changes
Feb 13, 2021
ldez
requested changes
Feb 13, 2021
|
Hey, @sspaink — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
ashanbrown
pushed a commit
to ashanbrown/golangci-lint
that referenced
this pull request
Feb 20, 2021
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238
This PR adds support for the revive linter. Tested by running
T=revive.go make test_linters, added a simple example config but all the configuration settings in revive have been implemented.I assume having this linter disabled by default is what would be wanted, not sure what it takes to be enabled by default.
Just let me know if there is anything you would like me to change, thanks!