Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to skip a directory #1912

Closed
jvrahav opened this issue Apr 15, 2021 · 1 comment
Closed

unable to skip a directory #1912

jvrahav opened this issue Apr 15, 2021 · 1 comment
Labels
question Further information is requested

Comments

@jvrahav
Copy link

jvrahav commented Apr 15, 2021

I have a code that is importing archive/zip package. I run golangci-lint against the code and all works fine in go1.15

however in go1.16 there was a change introduced in archive/zip/reader.go (https://go.googlesource.com/go/+/refs/tags/go1.16.3/src/archive/zip/reader.go#655)

I have the following linter configuration

linters:
disable-all: true
enable:
- deadcode
- dupl
- goconst
- gocyclo
- gofmt
- goimports
- golint
- govet
- ineffassign
- misspell
- nakedret
- structcheck
- unparam
- unused
- varcheck

golangcli-lint run command now fails with the following error

Running error: buildir: analysis skipped: errors in package: [src/server/pkg/iputil/iprange.go:13:2: could not import server/locerrors (src/server/locerrors/main.go:11:2: could not import server/pkg/locerror (src/server/pkg/locerror/locerror.go:6:2: could not import archive/zip (/gopath/linux64/src/archive/zip/reader.go:639:2: IsDir redeclared)))]

I believe skip-dirs loads the folder although i have set directory locerror to skip.

Can someone suggest on how i can work around this issue.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 15, 2021

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez closed this as completed Apr 15, 2021
@golangci golangci locked and limited conversation to collaborators Apr 15, 2021
@ldez ldez added the question Further information is requested label Apr 15, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants