Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lint of examples directory #416

Closed
Sean-Der opened this issue Mar 3, 2019 · 3 comments
Closed

Allow lint of examples directory #416

Sean-Der opened this issue Mar 3, 2019 · 3 comments

Comments

@Sean-Der
Copy link
Contributor

Sean-Der commented Mar 3, 2019

Hey @jirfag

golangci-lint is amazing, switching to it has made such a huge difference for my project. It is so nice to not manage all these linters on my own (and wasn't aware of how bad my code was before)

My repo pions/webrtc has an examples directory, and I would like to lint it. It is ignored by default here and I haven't found a way to override it.

Are there any hacks I can do to make this happen though? I noticed the quality of my examples slipping without this. For now I can exec twice, but that puts a bigger burden on contributors.

thanks!

@Sean-Der
Copy link
Contributor Author

Sean-Der commented Mar 6, 2019

@jirfag I would love to make the PR for this as well (if you have a suggestion on how you would like to see this implemented)

Can I expose excluded-directories as an argument, and make the default match the current behavior?

@jirfag
Copy link
Member

jirfag commented Mar 31, 2019

Hi!
I suggest making an analog of --exclude-use-default: --skip-dirs-use-default=true|false with enumerating all default skipped dirs in a help message

@Sean-Der
Copy link
Contributor Author

Hey @jirfag anything I can do to help get this merged? It would be really nice to be able to lint Pion using the hosted golang-ci

thanks!

@jirfag jirfag closed this as completed in f312a0f Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants