Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support autofixing of perfsprint #4453

Closed
G-Rath opened this issue Mar 4, 2024 · 3 comments
Closed

Support autofixing of perfsprint #4453

G-Rath opened this issue Mar 4, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@G-Rath
Copy link
Contributor

G-Rath commented Mar 4, 2024

Your feature request related to a problem? Please describe.

It seems that perfsprint supports some autofixing, but using --fix does not trigger it.

Describe the solution you'd like.

The ability to have volitions reported by perfsprint automatically fixed

Describe alternatives you've considered.

Manually running perfsprint --fix

Additional context.

No response
@G-Rath G-Rath added the enhancement New feature or improvement label Mar 4, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Mar 4, 2024

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

This was referenced Mar 4, 2024
Merged
Closed
@ldez ldez added declined area: docs and removed enhancement New feature or improvement labels Mar 4, 2024
@ldez
Copy link
Member

ldez commented Mar 4, 2024

Hello,

perfprint as a binary supports fix but not inside golangci-lint.

Related to #1779

@ldez ldez closed this as completed Mar 4, 2024
@ldez ldez added duplicate This issue or pull request already exists and removed declined area: docs labels Mar 4, 2024
@G-Rath
Copy link
Contributor Author

G-Rath commented Mar 4, 2024 •
edited
Loading

Is there something that perfsprint could do differently to enable that? I based my PR off dupword which supports -fix, is marked as autofixable, and also looks to be using SuggestedFixes.

Looks like dupword being marked as autofixable is the mistake, as it doesn't work with --fix for golangci-lint

@G-Rath G-Rath mentioned this issue Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: flag perfsprint as autofixable
2 participants
@G-Rath @ldez