Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation #888

Closed
marcosmol204 opened this issue Feb 18, 2021 · 22 comments
Closed

Spanish translation #888

marcosmol204 opened this issue Feb 18, 2021 · 22 comments
Labels

Comments

@marcosmol204
Copy link

Hello!
I would love to contribute with Spanish translation. It could be possible ?

@goldbergyoni
Copy link
Owner

@marcelosdm Welcome!1!@

@desko27 is the lord of this who already did tremendous work, he can probably suggest where exactly your contribution be most valuable

I know that @jormaechea has also worked on this recently 🚀

@marcosmol204
Copy link
Author

Hi @desko27 @jormaechea , can you contact me and tell me what I can translate.
My email is marcosmol204@gmail.com
Muchas gracias in advance.
Marcos

@jormaechea
Copy link

Hi @marcosmol204

I started from the issue linked in the README (#95 -- closed) and then created a PR (#769) where I fully translated sections 1 and 2.

I think that you can keep it going from section 3

@desko27
Copy link

desko27 commented Feb 21, 2021

Hi @marcosmol204, thank you for showing interest in contributing. I don't have the time I used to, but I can help with a PR review once you're done translating. There is a branch for spanish translation so anything you find untranslated there can actually be translated by anyone who is willing to.

@JhonRobert20
Copy link

Hi! @jormaechea @desko27 , Can I help with the spanish translation? I will be happy to help anywhere. Thank you!

@JFernando122
Copy link

Hi @desko27 i would like to contribute on the spanish translation. Is there any specific file you would like me to start working on?, or should i go translate whatever i see is missing?
Thank in advance.

@goldbergyoni
Copy link
Owner

Welcome aboard @JhonRobert20 @JFernando122 🌻

@JFernando122
Copy link

Thanks @goldbergyoni i'll start as soon as posible, only one thing...

It's my first contribution to a big project and i see that the spanish-translation branch is like 1.8k commits behind master, and i don't know what to do in cases like that, do i merge/rebase master and the start working on it?, or what do i do?

@goldbergyoni
Copy link
Owner

@desko27 Is spanish-translation branch still the place where we push spanish contributions to?

@JFernando122 Yes, merge/rebase seems sensible and inevitable, can you do a quick try to see how many conflicts exist?

@JFernando122
Copy link

This is what i get on VSCode.

image

image

image

image

What i found weird is that in there shows that the spanish files are in korean, but when i look on the files before rebasing, they are in spanish

@JhonRobert20
Copy link

Hello, sorry now, not the time I had when I wrote the previous time, thank you very much anyway. Sorry for the inconvenience

@goldbergyoni
Copy link
Owner

@JFernando122 Only 1-2 conflicts? If yes, I would not spend time on this. Just override the file with the English version and or a Spanish one if there was one ever

@JFernando122
Copy link

Sorry for the long time.
I rebased and make some work to push, but don't know if i did it properly.
image
Since i did the rebase it appears like 2k+ new commits but the actual changes are in the last 3 commits.
Just wanting to make sure i'm doing it right before making a bad pull request.
Again sorry for the inconvenience

@GeekBeardLinks
Copy link

Hi! I found out about this project today. Happy to help with the translation!

Although there is a lot of work to do, from what I could see 48 files in English changed from the arm in Spanish that were translated and 32 new files that have not been translated yet.

@GeekBeardLinks
Copy link

GeekBeardLinks commented Jul 10, 2021

Hi! I made PR #1031 to update spanish-translation branch with master. I do not made a rebase, just a plain old merge from master to the spanish-translation.

@JFernando122
Copy link

@GeekBeardLinks I already have updated translations for the sections(just waiting for you merge to go trough so i can add onto that):

  • main README.spanish.mg and writting-guidelines
  • errorhandling
  • performance
  • production
  • testingandquality

The sections that still need an update are:

  • codestylepractises
  • docker (completly missing all spanish translations)
  • projectstructure
  • security

@marcelimxo
Copy link

Hi! I found this project and I would love to help with the translation but I see that you have some work in progress but it's not very clear which parts are complete or not, can you let me know what is missing so I can help?

@GeekBeardLinks
Copy link

@goldbergyoni @BrunoScheufler @kevynb can you help us moving this forward? Fernando is waiting the spanish translation branch with PR #1031 to be updated to add his changes. Thanks!

@rluvaton
Copy link
Collaborator

@goldbergyoni @BrunoScheufler @kevynb can you help us moving this forward? Fernando is waiting the spanish translation branch with PR #1031 to be updated to add his changes. Thanks!

Thank you for being here! I'll ask someone to review it

@rluvaton
Copy link
Collaborator

rluvaton commented Jul 16, 2021

Merged, @JFernando122 you can now continue 😀

@goldbergyoni
Copy link
Owner

@JFernando122 @rluvaton 💜

@stale
Copy link

stale bot commented Apr 17, 2022

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Apr 17, 2022
@stale stale bot closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants