Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio sprite error when using html5 = true #775

Closed
themoonrat opened this issue May 30, 2017 · 1 comment
Closed

audio sprite error when using html5 = true #775

themoonrat opened this issue May 30, 2017 · 1 comment

Comments

@themoonrat
Copy link
Contributor

The commit stop html5 audio working for me (webaudio is fine)

39ac41c
Lines 1655 to 1661.

The following part of that gives an error

if (!self._webAudio && !self._node.ended)

Because self._node doesn't exist. I tried changing that to !sound._node.ended, because that location DOES exist, but the bug persists, because sound._node.ended always returns false.

I can replicate this in IE or Chrome, as long as .html5 = true is set. By removing the above lines, everything works fine.

I preload all sounds, and pass to Howler as a blob ... the opposite use case for why this code was introduced!

@goldfire
Copy link
Owner

goldfire commented Oct 6, 2017

Thanks for catching this, it should now be fixed on master!

bhaskarp-vg pushed a commit to ValueGlobal/howler.js that referenced this issue Feb 7, 2018
ringcrl pushed a commit to ringcrl/howler.js that referenced this issue Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants