Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab the MathJaX support PR from the blackfriday repo #4

Closed
kaushalmodi opened this issue Apr 16, 2018 · 4 comments
Closed

Grab the MathJaX support PR from the blackfriday repo #4

kaushalmodi opened this issue Apr 16, 2018 · 4 comments

Comments

@kaushalmodi
Copy link

Hello,

Can you please merge this PR: russross/blackfriday#412

It's a shame that such good PR's were ignored in the original repo without any comments or feedback.

PS: I assume you know the trick to merge any PR.. just add https://github.com/Vonng/blackfriday as a remote, and merge those commits from the v2 branch.

Copying the original author: @Vonng

@kjk kjk closed this as completed in 9bd36d8 Apr 16, 2018
@kaushalmodi
Copy link
Author

Wow! Thanks for this quick merge!

@kaushalmodi
Copy link
Author

@kjk BTW I wonder why you didn't credit the original author in that commit. The right way would be to set the original author as the commit author and yourself as only the commiter.

@kjk
Copy link
Contributor

kjk commented Apr 16, 2018

This wasn't a merge. The code diverged enough that I had to manually port it. And I don't speak advanced git.

@kaushalmodi
Copy link
Author

I don't speak advanced git.

If it were me, I'd learn enough git so that I retain the original authorship. That way, the original authors don't feel discouraged or cheated. Then you can have additional commits of your own tweaking that commit... Just something to note for future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants