-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insight-view-visualization height #5719
Comments
Hi there, Radek from the GD Technical support team here - you're right that the InsightView requires a set height, however this is (somewhat) intentional. It fits with the rest of the embedding features, most of our embedding actually requires or at least benefits from a set height, but it was overall considered okay to leave this up to the frontend devs using the features. Hope this helps! |
Thanks for your reply There is a height in the code generated in the workspace, but this is the height of div, which doesn't seem to be helpful for the display.There is a height in the code generated in the workspace, but this is the height of div, which doesn't seem to be helpful for the display. it as follows: const style = {height: 400}; export function MyComponent() {
} |
Hi!
We found this height and InsightView during the test. At the end of loading, because there was no height, the content could not be displayed.
@gooddata/sdk-ui-ext/esm/insightView/InsightView.js
React.createElement("div", { className: "insight-view-visualization",
// make the visualization div 0 height so that the loading component can take up the whole area
style: isLoadingShown ? { height: 0 } : {height: '400px'} },
If you set a fixed height, it will be displayed normally after loading, but if it is undefined, it will be blank after loading. Should you add a height parameter to InsightView?
export function MyComponent() {
const style = {height: 400};
return (
);
}
The text was updated successfully, but these errors were encountered: