Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insight-view-visualization height #5719

Open
hxnets opened this issue Dec 17, 2024 · 2 comments
Open

insight-view-visualization height #5719

hxnets opened this issue Dec 17, 2024 · 2 comments

Comments

@hxnets
Copy link

hxnets commented Dec 17, 2024

Hi!

We found this height and InsightView during the test. At the end of loading, because there was no height, the content could not be displayed.

@gooddata/sdk-ui-ext/esm/insightView/InsightView.js

React.createElement("div", { className: "insight-view-visualization",
// make the visualization div 0 height so that the loading component can take up the whole area
style: isLoadingShown ? { height: 0 } : {height: '400px'} },

If you set a fixed height, it will be displayed normally after loading, but if it is undefined, it will be blank after loading. Should you add a height parameter to InsightView?

export function MyComponent() {
const style = {height: 400};
return (








);
}

@TheRPMko
Copy link

Hi there,

Radek from the GD Technical support team here - you're right that the InsightView requires a set height, however this is (somewhat) intentional. It fits with the rest of the embedding features, most of our embedding actually requires or at least benefits from a set height, but it was overall considered okay to leave this up to the frontend devs using the features.

Hope this helps!

@hxnets
Copy link
Author

hxnets commented Dec 18, 2024

Hi there,

Radek from the GD Technical support team here - you're right that the InsightView requires a set height, however this is (somewhat) intentional. It fits with the rest of the embedding features, most of our embedding actually requires or at least benefits from a set height, but it was overall considered okay to leave this up to the frontend devs using the features.

Hope this helps!

Thanks for your reply
At present, there is no relevant height parameter for insight-view-visualization. According to my observation, when the page is initialized and opened, data can be displayed, but at the same time, it will enter the loading state, and data cannot be displayed after loading again. I tried to set the height to auto but it didn't work, so I must give a fixed height. At present, I use

There is a height in the code generated in the workspace, but this is the height of div, which doesn't seem to be helpful for the display.There is a height in the code generated in the workspace, but this is the height of div, which doesn't seem to be helpful for the display.

1734488491053

it as follows:

const style = {height: 400};

export function MyComponent() {

return (
    <div style={style}>
        <BackendProvider backend={backend}>
            <WorkspaceProvider workspace={workspace}>
                <InsightView
                    insight={insight}
                    showTitle={showTitle}
                />
            </WorkspaceProvider>
        </BackendProvider>
    </div>
);

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants