-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video subtitles not displaying correctly (overlapping) if there are overlapping time codes #10590
Comments
Correct presentation in this case depends on the subtitle format and data. Can you provide the source subtitle file? |
For SSA/ASS subtitles sideloaded from a file this should work. For SSA/ASS subtitles in MKV this is known not to work, implementing it is tracked by #10295. For Subrip subtitles this is known not to work, implementing it is tracked by #4794. I believe this should work for both WebVTT and TTML subtitles (though I haven't double checked). As @nigelmegitt says, please clarify what format subtitles you're asking about and provide a source file we can use to reproduce what you're seeing. |
Related data point: Overlapping regions and therefore text is permitted by the specification in generic TTML, but not in the IMSC or EBU-TT-D profiles that are commonly used for subtitles and captions. (this is not a comment on the implementation in ExoPlayer) |
Hey @BobbyJWhjr. We need more information to resolve this issue but there hasn't been an update in 14 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @BobbyJWhjr if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
ExoPlayer Version
2.18.1
Devices that reproduce the issue
All android devices. Tested on Samsung S22 Ultra, Oneplus 7 Pro
Devices that do not reproduce the issue
NA
Reproducible in the demo app?
Not tested
Reproduction steps
Play any media with overlapping media codes like some narrator speaking with background music then subtitles overlap with each other as depicted in image
Expected result
When there are subtitles with overlapping time codes, expected behaviour should be to display both subtitles at the same time, just stacked above/below each other.
Actual result
Media
NA
Bug Report
adb bugreport
to dev.exoplayer@gmail.com after filing this issue.The text was updated successfully, but these errors were encountered: