Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video subtitles not displaying correctly (overlapping) if there are overlapping time codes #10590

Closed
1 task
BobbyJWhjr opened this issue Sep 7, 2022 · 5 comments
Assignees

Comments

@BobbyJWhjr
Copy link

ExoPlayer Version

2.18.1

Devices that reproduce the issue

All android devices. Tested on Samsung S22 Ultra, Oneplus 7 Pro

Devices that do not reproduce the issue

NA

Reproducible in the demo app?

Not tested

Reproduction steps

Play any media with overlapping media codes like some narrator speaking with background music then subtitles overlap with each other as depicted in image

Expected result

When there are subtitles with overlapping time codes, expected behaviour should be to display both subtitles at the same time, just stacked above/below each other.

pxl_20220816_183726420

Actual result

Screen Shot 2022-08-16 at 12 02 36 PM

Media

NA

Bug Report

@nigelmegitt
Copy link

Correct presentation in this case depends on the subtitle format and data. Can you provide the source subtitle file?

@icbaker icbaker self-assigned this Sep 8, 2022
@icbaker
Copy link
Collaborator

icbaker commented Sep 8, 2022

For SSA/ASS subtitles sideloaded from a file this should work.

For SSA/ASS subtitles in MKV this is known not to work, implementing it is tracked by #10295.

For Subrip subtitles this is known not to work, implementing it is tracked by #4794.

I believe this should work for both WebVTT and TTML subtitles (though I haven't double checked).

As @nigelmegitt says, please clarify what format subtitles you're asking about and provide a source file we can use to reproduce what you're seeing.

@nigelmegitt
Copy link

Related data point: Overlapping regions and therefore text is permitted by the specification in generic TTML, but not in the IMSC or EBU-TT-D profiles that are commonly used for subtitles and captions. (this is not a comment on the implementation in ExoPlayer)

@google-oss-bot
Copy link
Collaborator

Hey @BobbyJWhjr. We need more information to resolve this issue but there hasn't been an update in 14 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@google-oss-bot
Copy link
Collaborator

Since there haven't been any recent updates here, I am going to close this issue.

@BobbyJWhjr if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.

@google google locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants