Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle files during playing #1649

Open
Bidp opened this issue Jul 2, 2016 · 8 comments
Open

Add subtitle files during playing #1649

Bidp opened this issue Jul 2, 2016 · 8 comments
Assignees

Comments

@Bidp
Copy link

Bidp commented Jul 2, 2016

Hi, I was wondering if it's possible in ExoPlayer to add a subtitle file during playing without interfering the play. For what I know is we have to inject the corresponding SampleSource to TextTrackRender's constructor, but sometimes users just store their subtitle files anywhere, and they'd like to add the file after the media starts to play.

@Hitexroid
Copy link

this is my question too !!!

@sonvp
Copy link

sonvp commented Sep 8, 2016

Me too.

@ojw28
Copy link
Contributor

ojw28 commented Sep 9, 2016

This is not currently supported (you'd have to prepare the player again, which would cause re-buffering before the playback resumed). Marking as an enhancement for the future.

@kunal-altbalaji

This comment has been minimized.

@xiaoxixi615
Copy link

Adding subtitles after player being prepared is really a common need, hope you will enhance this in the near future.

@ojw28 ojw28 assigned icbaker and unassigned ojw28 Oct 30, 2019
@ojw28 ojw28 changed the title Add subtitle files from external storage during playing Add subtitle files during playing Jan 17, 2020
@vikasacharya16

This comment has been minimized.

@akshansh01

This comment has been minimized.

@MBakhshi96
Copy link

Preparing the player again, has also a side effect when using PlaybackStatsListener. This causes the onSessionFinished callback to be called twice even though the playback has not finished, leading to erroneous analytics data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants