Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS: Playback re-buffers when toggling audio/closed-caption tracks #2718

Closed
ChmielowiecAlek opened this issue Apr 24, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@ChmielowiecAlek
Copy link

Description:

  • playback hangs for ~3 seconds when switching Closed Captions on
  • internally, a new SelectionOverride is used to enable Closed Captions by calling DefaultTrackSelector.setSelectionOverride
  • the player goes through an additional buffering state

Precondition:

  • a high-bandwidth network connection has been established

Reproduction steps:

  • run ExoPlayer demo application
  • select HLS and Apple16x9 basic stream
  • the playback is fluent
  • tap on the sceen to show buttons and press Text
  • switch from Default to CEA-608 and press OK
  • state changes to buffering and there is about 3 seconds long gap

Expected result:

  • Closed Captions do appear without disturbing the playback.

Actual result:

  • the playback is disturbed, re-buffering is performed.

Link to test content

https://devimages.apple.com.edgekey.net/streaming/examples/bipbop_16x9/bipbop_16x9_variant.m3u8

Version of ExoPlayer being used

r2.3.1

Device(s) and version(s) of Android being used

  • Huawei P8 lite (ALE-L21), Android 6.0, API 23
  • Xiaomi MIBOX3m Android 6.0.1, API 23

Logcat output captured from the device

logcat_output.txt

Bugreport

  • I will send it by email
@ojw28 ojw28 self-assigned this Apr 24, 2017
@ojw28
Copy link
Contributor

ojw28 commented Apr 24, 2017

Yes. This was a compromise we made deliberately in V2. We're aware it's annoying, but the way we used to achieve no disruption was technically incorrect for several reasons. We do plan to optimize it again in the future.

@ojw28 ojw28 added the bug label Apr 24, 2017
@ojw28 ojw28 changed the title Playback hangs for ~3 seconds when switching Closed Captions on HLS: Playback re-buffers when toggling audio/closed-caption tracks Jun 26, 2017
@ojw28
Copy link
Contributor

ojw28 commented Jul 10, 2017

Addressed in 06b3b3c in dev-v2.

@ojw28 ojw28 closed this as completed Jul 10, 2017
@google google locked and limited conversation to collaborators Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants