-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Somes wav files generate loud white noise at the end #4724
Comments
I don't think we can do anything to look at this unless we have sample content that reproduces the issue. |
@ojw28 |
This is already answered in the issue template that you would have seen when filing this issue:
|
Oups missed that as bugreport was not relevant to the issue :( Sorry and mail sent. |
@ojw28 @andrewlewis Did you get the samples? Is this something that could be fixed or are the wav broken and he should rip them again or convert them? Just to know what to tell the user (wait or start ripping / converting) |
We got the samples, thanks. The issue occurs when a WAV file has non-audio data appended onto the end (I don't know whether it's junk data, or useful metadata or something, but it's not audio). As an example, the first sample you provided has a file length of ~4.9MB, but the audio part of it ends at ~4.2MB. We currently try and play out the remainder of the file as audio too, which is what sounds like white noise. Playback does end eventually (I don't think it's true that the white noise continues indefinitely). Next steps are:
|
Hi, I'm the user who sent the original bug report to Tolriq. I read your comment about ExoPlayer playing non-audio data in the WAV and I tried an experiment:
As a further experiment, I tried embedding a larger image file into the audio file and the white noise played for longer. So it does look like that it's the embedded tags and image that are being played by ExoPlayer. I've already converted my few WAVs to FLACs and that has effectively cured the white noise problem for me. Thanks and best wishes. |
Fixed by 80e64e5 in |
Exoplayer 2.8.4
A user reported to me that some wav files generate loud white noise at the end of the playback of each track for about 1 second. (On multiple different devices)
But he was also able to provide me a wav file that triggers that bug at the end for unlimited duration.
The media is 4:16 duration, but after the end loud white noise until stop is pressed.
All can be easily reproduced via the demo player, but since I'm pretty sure the files he sent me are copyrighted don't know how to give you the urls without generating issues :)
The text was updated successfully, but these errors were encountered: