Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somes wav files generate loud white noise at the end #4724

Closed
Tolriq opened this issue Aug 24, 2018 · 8 comments
Closed

Somes wav files generate loud white noise at the end #4724

Tolriq opened this issue Aug 24, 2018 · 8 comments
Assignees
Labels

Comments

@Tolriq
Copy link
Contributor

Tolriq commented Aug 24, 2018

Exoplayer 2.8.4

A user reported to me that some wav files generate loud white noise at the end of the playback of each track for about 1 second. (On multiple different devices)

But he was also able to provide me a wav file that triggers that bug at the end for unlimited duration.
The media is 4:16 duration, but after the end loud white noise until stop is pressed.

All can be easily reproduced via the demo player, but since I'm pretty sure the files he sent me are copyrighted don't know how to give you the urls without generating issues :)

@ojw28
Copy link
Contributor

ojw28 commented Aug 24, 2018

I don't think we can do anything to look at this unless we have sample content that reproduces the issue.

@Tolriq
Copy link
Contributor Author

Tolriq commented Aug 24, 2018

@ojw28
Well the indirect question was how do I send you the said content without posting copyrighted content on a public place :)

@ojw28
Copy link
Contributor

ojw28 commented Aug 24, 2018

This is already answered in the issue template that you would have seen when filing this issue:

### Link to test content
Provide a link to media that reproduces the issue. If you don't wish to post it
publicly, please submit the issue, then email the link to
dev.exoplayer@gmail.com using a subject in the format "Issue #1234".

@Tolriq
Copy link
Contributor Author

Tolriq commented Aug 24, 2018

Oups missed that as bugreport was not relevant to the issue :(

Sorry and mail sent.

@Tolriq
Copy link
Contributor Author

Tolriq commented Sep 4, 2018

@ojw28 @andrewlewis Did you get the samples?

Is this something that could be fixed or are the wav broken and he should rip them again or convert them?

Just to know what to tell the user (wait or start ripping / converting)

@ojw28
Copy link
Contributor

ojw28 commented Sep 4, 2018

We got the samples, thanks. The issue occurs when a WAV file has non-audio data appended onto the end (I don't know whether it's junk data, or useful metadata or something, but it's not audio). As an example, the first sample you provided has a file length of ~4.9MB, but the audio part of it ends at ~4.2MB. We currently try and play out the remainder of the file as audio too, which is what sounds like white noise. Playback does end eventually (I don't think it's true that the white noise continues indefinitely). Next steps are:

  • We should fix this in ExoPlayer. The WAV header provides sufficient information for us to determine where the end of the audio data is located, so by stopping there we can fix the problem.
  • As an interim measure, your user should be able to fix the problem by re-encoding the media to not contain whatever the non-audio data is that's currently appended onto the end.

@ojw28 ojw28 added the bug label Sep 4, 2018
@Halloway66
Copy link

Hi,

I'm the user who sent the original bug report to Tolriq. I read your comment about ExoPlayer playing non-audio data in the WAV and I tried an experiment:

  1. I ripped a CD track to WAV with no tags or cover art embedded. File played OK with no white noise.
  2. I converted that WAV to FLAC (with Foobar2000) and added some track information and a cover art image. That file played OK too.
  3. I converted the FLAC back to WAV, retaining the tags and image. This one did play white noise at the end.

As a further experiment, I tried embedding a larger image file into the audio file and the white noise played for longer. So it does look like that it's the embedded tags and image that are being played by ExoPlayer.

I've already converted my few WAVs to FLACs and that has effectively cured the white noise problem for me.

Thanks and best wishes.

@ojw28
Copy link
Contributor

ojw28 commented Sep 5, 2018

Fixed by 80e64e5 in dev-v2.

@ojw28 ojw28 closed this as completed Sep 5, 2018
@google google locked and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants