Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FLV video seekable by a seekMap. #7378

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Make FLV video seekable by a seekMap. #7378

merged 5 commits into from
Oct 13, 2020

Conversation

shenwill
Copy link
Contributor

Tested and works fine.

@ojw28 ojw28 requested a review from kim-vde May 14, 2020 10:30
kim-vde
kim-vde reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@kim-vde kim-vde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests with a sample stream? You can find examples here and here. Thanks!

@kim-vde
Copy link
Contributor

kim-vde commented Aug 4, 2020

Any news for the tests?

@kim-vde
Copy link
Contributor

kim-vde commented Sep 25, 2020

Is this ready to be reviewed? I see that some parts of the code are commented.

@shenwill
Copy link
Contributor Author

Just checked in. Now it's ready to be reviewed. Thanks.

kim-vde added a commit that referenced this pull request Oct 13, 2020
@kim-vde
Read until the track formats are available in TestUtil.extractSeekMap()
c898e71 
Otherwise, some extractor tests are seeking without making sure that the
extractor has retrieved the formats.

This is needed for PR Issue: #7378.

PiperOrigin-RevId: 335934326
@kim-vde kim-vde merged commit 2e5f2f1 into google:dev-v2 Oct 13, 2020
@kim-vde
Copy link
Contributor

kim-vde commented Oct 13, 2020

I cleaned the pull request and merged the part about seeking in FLV files.

I didn't merge the part about parsing the frame rate and adding it to the format because:

  • It does not seem related to FLV seeking.
  • It is not clear what is the advantage of doing that.
  • The frame rate might be variable so I would avoid adding it the the format (which is generally constant).
    If you still want this part to be merged, please open a new pull request and explain what is the intention.

ojw28 pushed a commit that referenced this pull request Oct 21, 2020
@kim-vde @ojw28
Merge pull request #7378 from shenwill:dev-v2
8f04968 
PiperOrigin-RevId: 336875300
ojw28 pushed a commit that referenced this pull request Oct 21, 2020
@kim-vde @ojw28
Read until the track formats are available in TestUtil.extractSeekMap()
efaa296 
Otherwise, some extractor tests are seeking without making sure that the
extractor has retrieved the formats.

This is needed for PR Issue: #7378.

PiperOrigin-RevId: 335934326
@google google locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kim-vde kim-vde kim-vde left review comments

Assignees

@kim-vde kim-vde

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shenwill @kim-vde @ducanh3005 @googlebot @ojw28