New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore JMP and treat JX==JNX when diffing basic blocks #11

Open

cblichmann opened this issue Sep 21, 2023 · 1 comment

Labels

Member

cblichmann commented Sep 21, 2023

Steps to reproduce the problem:

Diff a program
Open a function with some differences
See some basic blocks which are marked as different only because of the jump at the end

What is the expected behavior?
See the following screenshot:

In such cases, it would be helpful for the blocks to be marked as equal.

What went wrong?
They are marked as different.

What version of the product are you using? On what operating system?
BinDiff 6, Win10.

Ported from b/175509898

cblichmann added the enhancement label

Member Author

cblichmann commented Sep 21, 2023 •

edited

Loading

These are actually two differeny things:

Ignore unconditional jumps at the end of a basic block when computing the small primes product (SPP)
Detect branch inversion

1 is easy to implement, for 2 we can either just treat all jumps the same or implement some heuristic that detects this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment