Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paste block in viewport/near cursor #7531

Closed
wants to merge 1 commit into from

Conversation

adrijanag17
Copy link

The basics

The details

Resolves

Fixes #6848

Proposed Changes

Pastes copied block in the center of viewport or near the original block depending on whether or not original is inside the viewport.

Reason for Changes

Copied blocks should not be pasted near original if original is not in viewport. The copied block should be visible in viewport.

Test Coverage

Documentation

Additional Information

@adrijanag17 adrijanag17 requested a review from a team as a code owner September 22, 2023 20:56
@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the PR: fix Fixes a bug label Sep 22, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to
    validate your changes on our
    developer site.

  • All contributors must sign the Google Contributor License
    Agreement (CLA). If the google-cla bot leaves a comment on this
    PR, make sure you follow the instructions.

  • We use conventional commits
    to make versioning the package easier. Make sure your commit
    message is in the proper format
    or learn how to fix it.

  • If any of the other checks on this PR fail, you can click on
    them to learn why. It might be that your change caused a test
    failure, or that you need to double-check the
    style guide.

Thank you for opening this PR! A member of the Blockly team will review it soon.

@rachel-fenichel
Copy link
Collaborator

Hey @adrijanag17, this bug is already being worked on in #752.

If you comment on a different issue, Beka or Maribeth will get you assigned to avoid overlaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste block in viewport / near cursor
3 participants