Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bump script from package.json #7548

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

SunMoon97
Copy link
Contributor

@SunMoon97 SunMoon97 commented Sep 27, 2023

The basics

The details

Resolves

Fixes #7543

Proposed Changes

Reason for Changes

Test Coverage

Documentation

Additional Information

@SunMoon97 SunMoon97 requested a review from a team as a code owner September 27, 2023 20:38
@SunMoon97 SunMoon97 requested a review from BeksOmega September 27, 2023 20:38
@google-cla
Copy link

google-cla bot commented Sep 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega
Copy link
Collaborator

BeksOmega commented Sep 27, 2023

Heya @SunMoon97 Thanks for submitting this fix :D Could you:

  1. Fill out the PR template.
  2. Fix your commit message. It should be chore: remove bump script from package.json. We automatically generate release notes from our commit messages, so they need to be specially formatted =)
  3. [EDIT: Also run npm run format and commit those changes.]

After that this should be good to go!

@SunMoon97 SunMoon97 changed the title Removed bump script from package.json #7543 chore: remove bump script from package.json Sep 28, 2023
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Sep 28, 2023
@SunMoon97
Copy link
Contributor Author

@BeksOmega I did as instructed .Please see to it.

package.json Outdated
@@ -98,7 +97,7 @@
"markdown-tables-to-json": "^0.1.7",
"mocha": "^10.0.0",
"patch-package": "^8.0.0",
"prettier": "3.0.3",
"prettier": "^3.0.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @SunMoon97, could you revert this change + the change to the package-lock? Prettier recommends using the exact version so that you make sure everyone is always formatting the files the same way!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Sep 29, 2023
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for your hard work on this!

@BeksOmega BeksOmega merged commit 04fa799 into google:develop Sep 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bump script in package.json
2 participants