Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling a target not in SUPPORTED_PLATFORM_TRIPLES silently generates BUILD files that won't work #467

Open
bsilver8192 opened this issue Feb 7, 2022 · 1 comment

Comments

@bsilver8192
Copy link
Contributor

I've got a few new Linux triples which aren't in SUPPORTED_PLATFORM_TRIPLES yet (PR to add them coming soon). It was tricky to figure out why a cfg(unix) dependency didn't work for them at first.

I think a warning or error when running raze with unsupported triples in targets would be helpful. Thoughts?

@dfreese
Copy link
Collaborator

dfreese commented Feb 8, 2022

If a user is explicitly specifying target triples, an error if we don't recognize that triple would make sense. I'd be supportive of that.

There's the bigger problem of keeping raze's triples in-sync with rust, and that's less obvious to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants